Add PodMutation custom resource example#501
Merged
vbaltrusaitis-castai merged 3 commits intomasterfrom Jun 11, 2025
Merged
Conversation
| ] | ||
| spotConfig = { | ||
| # mode can be "optional-spot", "only-spot", or "preferred-spot" | ||
| mode = "optional-spot" |
Contributor
There was a problem hiding this comment.
iirc only-spot is valid with distributionPercentage
Contributor
Author
There was a problem hiding this comment.
When I look at tests (for mothership mutations, and CR mutations mimic that behavior), it seems that distributionPercentage can be used with all modes: https://github.com/castai/pod-mutator/blob/main/internal/handler/partial_spot_test.go#L34. The code actually uses distributionPercentage either way and the only difference is what whether it removes some toleration, node selector, or affinity. Though maybe not all of those make sense to use equally.
mindaugasCast
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.