Conversation
Contributor
|
Could you also check if modules are using deprecated fields? Our EKS module seems to use some https://github.com/castai/terraform-castai-eks-cluster/blob/8e4a239f889d908fa5fa9e2881a97e891953f43a/main.tf#L1049 |
furkhat
reviewed
Jun 20, 2025
Contributor
furkhat
left a comment
furkhat
left a comment
There was a problem hiding this comment.
Could we use schema migrations so deprecated fields get migrated to node templates on provider upgrade?
furkhat
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates fields from autoscaler_settings:
headroomandheadroom_spot- reference this FAQ section for a replacement functionality.node_constraints- this field was moved from version 5.x.x and migration was advised.custom_instances_enabledthis field was moved from version 5.x.x and migration was advised.spot_instancesthis object have now equivalent configuration in default node template, migration was advised from version 5.x.x.Additionally removed/moved deprecated fields in examples.