feat: Suppress diff for default value of memory_event: apply_type: "immediate"#573
Merged
maaarcelino merged 4 commits intomasterfrom Sep 30, 2025
Merged
Conversation
UOndro
reviewed
Sep 29, 2025
|
|
||
| func suppressApplyTypeDefaultValueDiff(resource, oldValue, newValue string, d *schema.ResourceData) bool { | ||
| if isEmpty(newValue) { | ||
| applyType := d.Get(fmt.Sprintf("%s.0.%s", resource, FieldApplyType)) |
Contributor
There was a problem hiding this comment.
this will give you resource.apply_type, you probably want resource.memory_event.apply_type
Contributor
There was a problem hiding this comment.
I see resource has different meaning here. I don't think you need to pass it, just use FieldMemoryEvent
The reason why it was use in other function is that parent field is dynamic it can be either memory or cpu, in your case is static
Contributor
Author
There was a problem hiding this comment.
No because this translates into d.Get("memory_event.0.apply_type") of the scaling policy resource
UOndro
approved these changes
Sep 29, 2025
maaarcelino
changed the title
memory_event: apply_type: immediate
maaarcelino
changed the title
memory_event: apply_type: immediatememory_event: apply_type: "immediate"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.