Skip to content

KUBE-1773: Add NVME disk option for Ephemeral OS disk on AKS #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tsonov merged 2 commits into from
Feb 26, 2026
Merged

KUBE-1773: Add NVME disk option for Ephemeral OS disk on AKS #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e212d
Add NVME disk option
Tsonov Feb 25, 2026
c4ac37a
Docs
Tsonov Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions castai/resource_node_configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ const (
aksImageFamilyWindows2022 = "windows2022"
aksEphemeralDiskPlacementCacheDisk = "cacheDisk"
aksEphemeralDiskPlacementResourceDisk = "resourceDisk"
aksEphemeralDiskPlacementNVME = "nvmeDisk"
)

const (
Expand Down Expand Up @@ -361,8 +362,8 @@ func resourceNodeConfiguration() *schema.Resource {
"placement": {
Type: schema.TypeString,
Required: true,
Description: "Placement of the ephemeral OS disk. One of: cacheDisk, resourceDisk",
ValidateDiagFunc: validation.ToDiagFunc(validation.StringInSlice([]string{aksEphemeralDiskPlacementCacheDisk, aksEphemeralDiskPlacementResourceDisk}, true)),
Description: "Placement of the ephemeral OS disk. One of: cacheDisk, resourceDisk, nvmeDisk",
ValidateDiagFunc: validation.ToDiagFunc(validation.StringInSlice([]string{aksEphemeralDiskPlacementCacheDisk, aksEphemeralDiskPlacementResourceDisk, aksEphemeralDiskPlacementNVME}, true)),
DiffSuppressOnRefresh: true,
DiffSuppressFunc: func(k, oldValue, newValue string, d *schema.ResourceData) bool {
return strings.EqualFold(oldValue, newValue)
Expand Down Expand Up @@ -1234,6 +1235,8 @@ func toAKSEphemeralOSDisk(obj any) *sdk.NodeconfigV1AKSConfigOsDiskEphemeral {
osDisk.Placement = lo.ToPtr(sdk.NodeconfigV1AKSConfigOsDiskEphemeralPlacementPLACEMENTRESOURCEDISK)
case strings.ToLower(aksEphemeralDiskPlacementCacheDisk):
osDisk.Placement = lo.ToPtr(sdk.NodeconfigV1AKSConfigOsDiskEphemeralPlacementPLACEMENTCACHEDISK)
case strings.ToLower(aksEphemeralDiskPlacementNVME):
osDisk.Placement = lo.ToPtr(sdk.NodeconfigV1AKSConfigOsDiskEphemeralPlacementPLACEMENTNVMEDISK)
}
}

Expand Down Expand Up @@ -1420,6 +1423,8 @@ func fromAKSEphemeralOSDisk(sdkEph *sdk.NodeconfigV1AKSConfigOsDiskEphemeral) []
m["placement"] = aksEphemeralDiskPlacementResourceDisk
case sdk.NodeconfigV1AKSConfigOsDiskEphemeralPlacementPLACEMENTCACHEDISK:
m["placement"] = aksEphemeralDiskPlacementCacheDisk
case sdk.NodeconfigV1AKSConfigOsDiskEphemeralPlacementPLACEMENTNVMEDISK:
m["placement"] = aksEphemeralDiskPlacementNVME
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/resources/node_configuration.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading