Skip to content

fix: align Go version to 1.24.0 across all CI workflows and fix Makefile#655

Open
Rayhan1967 wants to merge 1 commit intocastai:masterfrom
Rayhan1967:fix/ci-workflow-consistency
Open

fix: align Go version to 1.24.0 across all CI workflows and fix Makefile#655
Rayhan1967 wants to merge 1 commit intocastai:masterfrom
Rayhan1967:fix/ci-workflow-consistency

Conversation

@Rayhan1967
Copy link

Description

This PR fixes inconsistencies in the CI/CD configuration and resolves the Makefile lint target execution issue.

Problem

  1. Go Version Mismatch: The CI workflows were using Go 1.23.6 while go.mod specifies Go 1.24.0, causing potential compatibility issues during builds and tests.
  2. Lint Target Failure: The make lint command fails with "golangci-lint: No such file or directory" because the installed binary is not in the PATH.

Solution

  • Updated Go version to 1.24.0 in all CI workflow files to align with go.mod
  • Fixed the Makefile lint target to use the explicit path $(HOME)/go/bin/golangci-lint

Files Changed

File Change
.github/workflows/golangci-lint.yml Go version: 1.23.6 → 1.24.0
.github/workflows/doc.yaml Go version: 1.23.6 → 1.24.0 (2 occurrences)
Makefile Added explicit path for golangci-lint binary

Verification

  • ✅ Unit tests pass
  • ✅ Lint passes
  • ✅ Terraform format check passes

@Rayhan1967 Rayhan1967 requested a review from a team as a code owner March 4, 2026 16:35
@oskarwojciski
Copy link
Member

Why not upgrade all to 1.25 or 1.26?

@Rayhan1967
Copy link
Author

Why not upgrade all to 1.25 or 1.26?

As you can see in the file changes, this PR only touches the CI workflows and Makefile. Upgrading to Go 1.26 would require to update go.mod and test all dependencies, which is better suited for a separate, dedicated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants