Conversation
Updates {hnsw and hnsw-sqv} x {onnx and cached} for both BEIR and MS MARCO: code updated, parameters re-tuned.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98022af436
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3151 +/- ##
============================================
- Coverage 74.67% 74.12% -0.55%
- Complexity 1822 1830 +8
============================================
Files 201 204 +3
Lines 13684 13769 +85
Branches 1804 1818 +14
============================================
- Hits 10218 10206 -12
- Misses 2737 2836 +99
+ Partials 729 727 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lilyjge
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch
lucene10is a long-lived feature branch for upgrading to Lucene 10. The idea is that all other Lucene 10 features would be PRed against this branch, and when we're ready, we can merge this to master in one go.That means we should keep this branch always mergeable to master.
WIP, will keep in draft form until we're ready to merge.