[codex] Fix flaky CACM reproduction test assertion#3324
Open
lintool wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3324 +/- ##
=========================================
Coverage 73.39% 73.40%
- Complexity 1912 1914 +2
=========================================
Files 206 206
Lines 13493 13493
Branches 1867 1867
=========================================
+ Hits 9903 9904 +1
Misses 2843 2843
+ Partials 747 746 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
hm, seems like this is a misleading bug we should fix in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReproduceFromPrebuiltIndexesTest.testCacmEndToEnd.0 of 1or1 of 1CACM indexes.Root Cause
ReproduceFromPrebuiltIndexesprints the index-size table before retrieval runs. If CACM is already cached, the table saysTotal size across 1 of 1 indexes; if the cache is cold, it says0 of 1 indexes.That cache state is not the actual end-to-end success condition. The child
SearchCollectioncommand can lazily fetch/open the CACM prebuilt index after the summary is printed, then produce the expected run and metrics. The old assertion therefore depended on whether the local cache had been warmed by a prior run.Validation
mvn -Dtest=ReproduceFromPrebuiltIndexesTest#testCacmEndToEnd -Dpyserini.cache=tmp/pyserini-cache-flake-check testmvn -Dtest=ReproduceFromPrebuiltIndexesTest testBoth passed.