Open
Conversation
Member
Author
|
Side Note: We have some duplicated code e.g. pyserini/pyserini/encode/_tct_colbert.py Line 72 in 184a212 and pyserini/pyserini/search/faiss/_searcher.py Line 147 in 184a212 Is there a particular reason we are keeping both? |
Member
|
@jacklin64 @justram can either of you take a look at this? |
Member
Author
|
Bump on this @jacklin64 @justram . Evaluating with this python -m pyserini.search.faiss \
--index msmarco-v1-passage.tct_colbert.hnsw \
--topics msmarco-passage-dev-subset \
--encoder castorini/tct_colbert-msmarco \
--encoder-class mlx_tct_colbert \
--output runs/run.msmarco-passage.tct_colbert.hnsw.tsv \
--output-format msmarco \
--use_mlx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could probably do with some redesign but here's a first pass at integrating MLX into Pyserini with ColBERT.
The tests and test outputs are similar to the same tests for the PyTorch hugging face implementation