Support gzipped (.jsonl.gz) input in pyserini.encode - #2626
Draft
yashs33244 wants to merge 1 commit into
Draft
Conversation
JsonlCollectionIterator only read plain-text files, so a gzipped corpus had to be decompressed first even though pyserini.index.lucene already accepts .jsonl.gz. Open .gz inputs with gzip so pyserini.encode accepts them too. Adds a test that reads a .jsonl.gz identically to the plain file. Closes castorini#1908.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1908.
JsonlCollectionIteratoronly read plain-text files, so encoding a gzipped corpus meant decompressing it first, even thoughpyserini.index.lucenealready accepts.jsonl.gz. This opens.gzinputs withgzipsopyserini.encodeaccepts them too (works for a single file and a directory of files). Plain.jsonlinput is unchanged.Added a test that reads a
.jsonl.gzand asserts it matches the plain fixture.Opening as a draft for review.