Add to onboarding reproduction logs - #2653
Open
akhilmajhi2006 wants to merge 2 commits into
Open
Conversation
Member
|
Please don't add any extra files. |
Author
|
Hi Jimmy,
Thanks for pointing this out. I’ve completed the earlier onboarding lessons
and exercises as well. I had only added the Lesson 8 reproduction log to
the PR, which is why the earlier lessons aren't reflected there.
I’ve also removed the extra revision file/change from the PR.
Best,
Akhil
… Message ID: ***@***.***>
|
Member
I believe the instructions were clear about appending an entry for every lesson? |
Author
|
Thanks for pointing this out. I initially only added the Lesson 8 reproduction entry. I have now updated the Pyserini PR to include the reproduction-log entries for the earlier conceptual-framework lessons as well. The Anserini and Pyserini work was completed separately in their respective repositories. |
Member
|
You're still missing repro entries... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced the Lesson 8 onboarding exercise for SPLADE-v3.
Environment:
Results:
The reproduction log has been added to docs/conceptual-framework3.md.