Skip to content

[codex] Vendor MS MARCO evaluators and fix Python warnings - #2657

Open
lintool wants to merge 1 commit into
masterfrom
codex/vendor-msmarco-evaluators
Open

[codex] Vendor MS MARCO evaluators and fix Python warnings#2657
lintool wants to merge 1 commit into
masterfrom
codex/vendor-msmarco-evaluators

Conversation

@lintool

@lintool lintool commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

  • vendor the MS MARCO passage and document evaluation scripts in Pyserini
  • run the vendored evaluators with the active Python interpreter instead of downloading them at runtime
  • remove obsolete evaluation-script download metadata and utilities
  • fix Python 3.12 invalid escape sequence and unclosed file warnings
  • modernize the MS MARCO run converter to use an f-string

Validation

  • mamba run -n pyserini-dev3 python -Werror::SyntaxWarning -m compileall -f -q pyserini
  • mamba run -n pyserini-dev3 python -m unittest tests.base.test_trectools tests.base.test_load_qrels
  • mamba run -n pyserini-dev3 python -Werror::SyntaxWarning -m pyserini.eval.msmarco_passage_eval
  • mamba run -n pyserini-dev3 python -Werror::SyntaxWarning -m pyserini.eval.msmarco_doc_eval
  • git diff --check

@lintool

lintool commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

Yes, Codex uses "vendor" as a verb...

@lintool
lintool marked this pull request as ready for review August 29, 2026 20:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T20:18:44.182090Z 772bcc6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant