Skip to content

Type modern server entry points#376

Draft
branta42 wants to merge 1 commit intorank-llm-mypy-gate-2from
rank-llm-mypy-gate-3
Draft

Type modern server entry points#376
branta42 wants to merge 1 commit intorank-llm-mypy-gate-2from
rank-llm-mypy-gate-3

Conversation

@branta42
Copy link
Copy Markdown
Member

@branta42 branta42 commented Apr 1, 2026

Summary

  • add strict mypy coverage for the modern MCP/server entry points and adjacent HTTP/MCP CLI tests
  • annotate MCP server construction and transport handling instead of leaving those paths untyped
  • make CLI console-script tests resolve the repo-local .venv entrypoint so they pass consistently under and outside the quality gate

Testing

  • JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64 PATH=/usr/lib/jvm/java-21-openjdk-amd64/bin:/store2/scratch/rpradeep/castorini-monorepo/rank_llm/.venv/bin:$PATH .venv/bin/python scripts/quality_gate.py
  • PATH=/store2/scratch/rpradeep/castorini-monorepo/rank_llm/.venv/bin:$PATH .venv/bin/python -m unittest test.test_cli_http test.test_cli_mcp
  • .venv/bin/python -m mypy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants