Skip to content

Remove tensorrt-llm from optional-dependencies for uv compat #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronakice merged 2 commits into from
Apr 2, 2026
+4 −5
Merged

Remove tensorrt-llm from optional-dependencies for uv compat #378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f056b45
Remove tensorrt-llm from optional-dependencies for uv compatibility
ronakice Apr 2, 2026
cb06891
Remove uv.lock from tracked files
ronakice Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ sglang = [
"rank-llm[local]",
"sglang[all]~=0.4.0"
]
tensorrt-llm = [
"rank-llm[local]",
"tensorrt-llm[all]>=0.14.0"
]
# tensorrt-llm is not declarable as a uv-resolvable extra because the PyPI
# stub needs NVIDIA's index and the NVIDIA wheel carries git-URL deps that
# uv rejects. Install manually:
# pip install --extra-index-url https://pypi.nvidia.com/ 'rank-llm[local]' 'tensorrt-llm[all]>=0.14.0'
Comment on lines +59 to +62
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep tensorrt-llm extra defined for setup compatibility

Removing the tensorrt-llm optional dependency key makes existing setup commands fail immediately (for example, uv sync --group dev --extra tensorrt-llm now errors with “Extra tensorrt-llm is not defined”), which breaks documented TensorRT-LLM onboarding and any local/CI automation that still references that extra name. Even if TensorRT itself must be installed manually, preserving a compatibility extra (or updating all usage sites in the same change) avoids this regression.

Useful? React with 👍 / 👎.

pyserini = [
"faiss-cpu>=1.8.0",
"pandas>=1.4.0",
Expand Down Expand Up @@ -98,7 +98,6 @@ all = [
"rank-llm[pyserini]",
"rank-llm[server]",
"rank-llm[sglang]",
"rank-llm[tensorrt-llm]",
"rank-llm[training]",
"rank-llm[vllm]",
]
Expand Down
Loading