Signature selection improvements #907
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing one interferes with the one used by the rbs repo, so we overlap numbers when not all arguments of a method are anonymous
* Ensure method aliases are processed with resolve_generics() * Avoid an extra hop in get_methods() resulting in no alias resolution
apiology
commented
Apr 29, 2025
| @@ -1052,6 +1052,25 @@ def foo a | |||
| expect(clip.infer.to_s).to eq('Foo, Bar') | |||
| end | |||
|
|
|||
| # pending https://github.com/castwide/solargraph/pull/836 | |||
| xit 'handles parallel type possibilities with #nil?' do | |||
There was a problem hiding this comment.
I suspect there will also some untested related regressions with this PR solo - to be safe, I think we should release this PR in the same release as #836 . I'll keep them as separate PRs for ease of review in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
['Boolean', 'self', nil].include?(tag)to typecheck