-
Notifications
You must be signed in to change notification settings - Fork 27
introduce new_with_rmt_driver() to be able to use multiple mem blocks for TxRmtDriver to mitigate flickering #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce new_with_rmt_driver() to be able to use multiple mem blocks for TxRmtDriver to mitigate flickering #62
Conversation
I tried it and on my first tests this improved it a lot. I stil got veeeery few flickerings, but in dev mode. I expect it to be even better in production mode. My test just used one extra thread with a webserver set up using std threads. Before this change the leds freaked out with this configuration. |
@weber-software Thank you for great survey and PR. This fix also corresponds to the contents of the following URL, so it is a good workaround.
But, the fundamental fix should be to be able to change mem_block_num. For example, there is a report on the latter forum post that says the issue was solved by setting mem_block_num = 8. |
@cat-in-136 i agree that it would be a good idea to make the
|
@weber-software It would be appropriate to create a builder for Ws2812Esp32RmtDriver. I havenot investigated yet what to do for smartled and embeddedgraphics: passing driver as argument or create a builder for each? (The existing new() function should be retained. These legacy functions are still useful for convenience.) |
47f4577
to
f5f70d6
Compare
@cat-in-136 i scribbled around a bit and came to the conclusion that it could be useful to have a function that accepts a |
f5f70d6
to
6434316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weber-software Could you please my review comment on lib_smart_leds.rs? Thank you.
Thanks a lot! |
I had the issue that my output was flickering like describe over here: #33
Using two mem blocks solved the flickering entirely for me (and i think for many others).