-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add SEC 10-k example notebook #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In it's final version, we'll want to add some copy up top about what the data is, where to find documentation, and what we're going to do with it.
Reply via ReviewNB
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is central_index_key a field that someone working with the data would be comfortable with? Without more context, it's not clear to me why this is an important first step or what the motivation is here.
Reply via ReviewNB
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this wind up getting used somewhere? It's not clear to me what the application is at present.
Reply via ReviewNB
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels more oriented towards characterizing data completion. Narratively, I think it'd make more sense for the notebook to focus on data utilization - e.g., how do I get total generation for a series of nested entities or get a list of all plants owned by one entity and its subsidiaries? You could focus in on one entity for narrative simplicity.
Reply via ReviewNB
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above - this feels like characterizing data quality, not demonstrating how to best use the data.
Reply via ReviewNB
| @@ -0,0 +1,642 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
What problem does this address?
What did you change in this PR?
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list