forked from microsoft/moodle-auth_oidc
-
Notifications
You must be signed in to change notification settings - Fork 1
Allow OIDC with Azure B2C #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Peterburnett
wants to merge
29
commits into
TOTARA_160_STABLE-catalyst
Choose a base branch
from
azureb2c
base: TOTARA_160_STABLE-catalyst
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of places where the client_secret should not be passed to Azure B2C as part of the authentication requests. B2C is picky about this, and will reject the token grant if passed. The data bindings also needed to be improved and allowed to suit custom values, as the B2C data bindings are different to the default bindings in AAD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of places where the client_secret should not be passed to Azure B2C as part of the authentication requests. B2C is picky about this, and will reject the token grant if passed. The data bindings also needed to be improved and allowed to suit custom values, as the B2C data bindings are different to the default bindings in AAD.