Issue 387: Add metadata header to outage pages #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peterburnett
force-pushed
the
issue-387
branch
2 times, most recently
from
dce3e20 to
fe6d323
Compare
Peterburnett
force-pushed
the
issue-387
branch
from
fe6d323 to
a9c2ce3
Compare
Contributor
Author
|
Tests are passing, other CI failures are due to new linter rules. Not addressing in this PR, as this one is for a legacy branch |
| <FIELD NAME="lastmodified" TYPE="int" LENGTH="10" NOTNULL="true" SEQUENCE="false" COMMENT="When was this entry last modified."/> | ||
| <FIELD NAME="finished" TYPE="int" LENGTH="10" NOTNULL="false" SEQUENCE="false" COMMENT="Timestamp of when the outage really finished."/> | ||
| <FIELD NAME="accesskey" TYPE="char" LENGTH="16" NOTNULL="false" SEQUENCE="false" COMMENT="Unique key used to access during outage"/> | ||
| <FIELD NAME="metadata" TYPE="char" LENGTH="1333" NOTNULL="false" SEQUENCE="false" COMMENT="metadata to be exposed in outage page headers"/> |
Contributor
There was a problem hiding this comment.
the mform field's max length is 255 - so this should be 255 as well (1333 seems like a random number - was there a specific reason for this length?)
Contributor
There was a problem hiding this comment.
or better yet just text?
|
|
||
| // Define field metadata to be added to auth_outage. | ||
| $table = new xmldb_table('auth_outage'); | ||
| $field = new xmldb_field('metadata', XMLDB_TYPE_CHAR, '1333', null, null, null, null, 'accesskey'); |
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info page:
Preview page:
CLI Maintenance page:
