Fix behat tests and the display of completion conditions (4.4 variant) #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Behat deprecation for Moodle 4.4
Member
|
Thanks heaps for the PR! - I've just created a MOODLE_405_STABLE branch in the repo here if you get a chance to send through a PR, I'll merge that in too and then will update the default branch to point at it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combo-PR covering issues 86 and 93, including the patch for issue 97 by Julian-Tovar. I have a 4.5 variant which caters for a difference in some of the Behat scenarios and bumps up the Moodle version requirement, but there's no base branch yet to merge against.