[#157] Fix inverted hash comparison in filter_indexed_files causing full file reindex#158
Merged
Merged
Conversation
…ausing full file reindex
Member
|
@tsmilan can you please bump a version? |
Contributor
Author
|
Thanks @dmitriim I've added a version bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a one-character typo
!=instead of==in thefilter_indexed_files()when comparing the content hash in the$unchangedboolean. This meant unchanged files evaluated to$unchanged = falseand were queued for re-indexing on every incremental run, even when nothing had changed.Testing Instructions
and run the indexer
search_index_taskFixes #157