Skip to content

cache_config: ensure cache is unready for storereqsnotmet test #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmarsden merged 1 commit into from
Mar 5, 2025
Merged

cache_config: ensure cache is unready for storereqsnotmet test #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions classes/cache_config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,17 @@ private function generate_store_instance_config(array $stores): array {

// Create instance from this definition and confirm it instantiates correctly.
$classinstance = new $classname($storearr['name'], $storearr['configuration']);
if (!$classinstance->is_ready()) {
$isready = $classinstance->is_ready();
if (PHPUNIT_TEST && $storearr['name'] == 'apcutest') {
$isready = false;
}
if ($isready) {
$storesarr[$name] = $storearr;
} else {
// Store the errored store here. Later we will check if it can be safely removed from the array,
// If its mappings are exclusively localisable.
$this->storeerrors[] = $name;
}
$storesarr[$name] = $storearr;
}

// Now instantiate the default stores (Must always exist).
Expand Down
Loading