Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpdocs and resume checks #593

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Add phpdocs and resume checks #593

merged 6 commits into from
Jul 5, 2024

Conversation

jay-oswald
Copy link
Contributor

No description provided.

@jay-oswald jay-oswald marked this pull request as ready for review July 5, 2024 06:06
@jwalits jwalits merged commit e90dc51 into MOODLE_310_STABLE Jul 5, 2024
18 checks passed
@danmarsden
Copy link
Member

looks like this got merged into the older branch before it landed in the newest branch - we didn't have the latest branch set as the default.
@jay-oswald @jwalits can you please check to see what still needs to be pulled across here to the newer branch? - MOODLE_402_STABLE?

@danmarsden danmarsden deleted the add-phpdocs branch July 29, 2024 21:15
matthewhilton pushed a commit that referenced this pull request Jul 29, 2024
* Re-instate workflow and add initial phpdoc

* Add placeholder phpdocs

* linting

* fix privacy

* empty commit to re-run tests

* add provider back
matthewhilton pushed a commit that referenced this pull request Jul 29, 2024
* Re-instate workflow and add initial phpdoc

* Add placeholder phpdocs

* linting

* fix privacy

* empty commit to re-run tests

* add provider back
@matthewhilton
Copy link
Contributor

matthewhilton commented Jul 29, 2024

@danmarsden FYI i've included it in my code standards fixup PR #622

matthewhilton pushed a commit that referenced this pull request Jul 29, 2024
* Re-instate workflow and add initial phpdoc

* Add placeholder phpdocs

* linting

* fix privacy

* empty commit to re-run tests

* add provider back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants