Issue #596: SQL change with some performance / resource improvements #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Josh, this is looking good. You'll see I've added some comments to resolve but once we've sorted that out, I'll create a 4.2 branch and merge this |
michaelkotlyar
changed the base branch from
MOODLE_310_STABLE
to
MOODLE_402_STABLE
michaelkotlyar
deleted the
MOODLE_402_STABLE_issue596_gen_report_sql_tweaks
branch
|
Hey Josh, all merged to our new MOODLE_402_STABLE branch. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#596
Updated SQL for the generate_status_report task using Common Table Elements.
In testing, these queries use less resources and complete faster compared to current ones.
Tested on MySQL 8 and PosgreSQL 14.
NOTE: the
WITHclause is supported in MySQL since version 8 but not 5.7. Since 12 in PostgreSQL.So I think we may need a base branch MOODLE_402_STABLE and then change this PR to merge to that base branch.