Repository navigation
Stop shifting the second TDT block's reward TTLs twice - #58
Merged
Merged
Conversation
15 tasks done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pauladkisson
force-pushed
the
split_tanks
branch
from
October 20, 2026 16:48
9564353 to
52757f8
Compare
pauladkisson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
Details (AI-generated)
Seiler2024NWBConverter.get_second_block_ttl_timestamps, which returnsttl_timestamps2 + t_endinstead of shifting the block's onsets in place. The second block is still placed right after the first; Sessions recorded in two TDT blocks lose the time between blocks #65 covers that.tests/test_split_recordings.pyhas one case shaped like 139.298 (nose-poke TTL already contains the rewards) and one like 92.246 (it does not).pytest tests: 22 passed. Onmainboth fail, returning[105, 107, 205]and[107, 205]instead of[105, 107].double_shift.ipynb) reconverts the three split sessions. In each fixed file, the only dataset that differs from the published file is the rewarded-side nose pokes of 139.298 (6 duplicates removed) and 92.246 (16 pokes moved from twice the offset to the offset). 332.393 is unchanged.🤖 Generated with Claude Code