Skip to content

Disambiguate the device model from device instance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 3, 2025

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Feb 6, 2025

@alessandratrapani alessandratrapani linked an issue Feb 6, 2025 that may be closed by this pull request
@alessandratrapani alessandratrapani marked this pull request as draft February 6, 2025 10:12
@alessandratrapani alessandratrapani changed the title Remove DeviceModel Disambiguate the device model from device instance Feb 6, 2025
@alessandratrapani alessandratrapani requested a review from rly May 28, 2025 15:20
@alessandratrapani alessandratrapani marked this pull request as draft May 28, 2025 15:31
@alessandratrapani alessandratrapani marked this pull request as ready for review May 28, 2025 16:01

**Device Instance Classes:**

- **DeviceInstance** extends ``Device`` to hold metadata on device instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change to the NWB schema does not include a DeviceInstance type. Device is just redefined to be instances or models. Do you think it would be useful to create a new DeviceInstance type? I can see some value to say that if we redefine Device to be instances, then the inheritance of a DeviceModel from a Device doesn't quite make sense, but it is simpler. Could you add your thoughts on this to NeurodataWithoutBorders/nwb-schema#608 ?

Copy link
Collaborator Author

@alessandratrapani alessandratrapani May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no sorry it was just a way to test this new version without the changes in --> NeurodataWithoutBorders/nwb-schema#608 and I needed to give it a different name
I was planning to remove those two object once NeurodataWithoutBorders/nwb-schema#608 is merged

@rly rly self-requested a review May 28, 2025 17:45
@alessandratrapani alessandratrapani self-assigned this May 30, 2025
@alessandratrapani alessandratrapani merged commit 0ad1a6d into main Jun 3, 2025
5 checks passed
@alessandratrapani alessandratrapani deleted the ophys-devices-inherit-from-device branch June 3, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ophys devices should inherit from device
2 participants