-
Notifications
You must be signed in to change notification settings - Fork 0
Disambiguate the device model from device instance #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… add FiberInsertion and LensPositioning definitions
…lLensModel; update related mock functions and tests
…he parent type; update mock functions and tests accordingly
… and instance descriptions
…tance definitions
|
||
**Device Instance Classes:** | ||
|
||
- **DeviceInstance** extends ``Device`` to hold metadata on device instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed change to the NWB schema does not include a DeviceInstance
type. Device
is just redefined to be instances or models. Do you think it would be useful to create a new DeviceInstance
type? I can see some value to say that if we redefine Device
to be instances, then the inheritance of a DeviceModel
from a Device
doesn't quite make sense, but it is simpler. Could you add your thoughts on this to NeurodataWithoutBorders/nwb-schema#608 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no sorry it was just a way to test this new version without the changes in --> NeurodataWithoutBorders/nwb-schema#608 and I needed to give it a different name
I was planning to remove those two object once NeurodataWithoutBorders/nwb-schema#608 is merged
Waiting for #607 to be merged