Disambiguate the device model from device instance #5
Conversation
alessandratrapani
changed the title
… add FiberInsertion and LensPositioning definitions
…lLensModel; update related mock functions and tests
…he parent type; update mock functions and tests accordingly
… and instance descriptions
…tance definitions
|
|
||
| **Device Instance Classes:** | ||
|
|
||
| - **DeviceInstance** extends ``Device`` to hold metadata on device instances. |
There was a problem hiding this comment.
The proposed change to the NWB schema does not include a DeviceInstance type. Device is just redefined to be instances or models. Do you think it would be useful to create a new DeviceInstance type? I can see some value to say that if we redefine Device to be instances, then the inheritance of a DeviceModel from a Device doesn't quite make sense, but it is simpler. Could you add your thoughts on this to NeurodataWithoutBorders/nwb-schema#608 ?
There was a problem hiding this comment.
Ah no sorry it was just a way to test this new version without the changes in --> NeurodataWithoutBorders/nwb-schema#608 and I needed to give it a different name
I was planning to remove those two object once NeurodataWithoutBorders/nwb-schema#608 is merged
Waiting for #607 to be merged