Conversation
for more information, see https://pre-commit.ci
…0. I think they should be allowed to be 0-length
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
Why break the pattern of the other interfaces and functions where the data and metadata are in separate streams? Here we send them both through the columns. How are you thinking about it?
| TimeIntervals=dict( | ||
| trials=dict( | ||
| columns=dict( | ||
| start_time=dict(description="start time of the trial"), |
There was a problem hiding this comment.
Isn't this overwritten by the schema by default? the description of start_time and stop_time?
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ |
There was a problem hiding this comment.
Shouldn't description be required as well?]
from pynwb.testing.mock.file import mock_NWBFile
nwbfile = mock_NWBFile()
nwbfile.add_trial_column(name='correct')Throws an error.
| columns=dict( | ||
| start_time=dict(description="start time of the trial"), | ||
| stop_time=dict(description="stop time of the trial"), | ||
| correct=dict(description="correct or not"), |
There was a problem hiding this comment.
I was expecting that you had to pass the name inside the dictionary as well from reading the schema, but here, the name here is only passed as the dictionary key.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 91.44% 91.37% -0.08%
==========================================
Files 127 127
Lines 7525 7556 +31
==========================================
+ Hits 6881 6904 +23
- Misses 644 652 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
fix #997