Skip to content

Conversation

@vient
Copy link

@vient vient commented Sep 9, 2023

Description

Fix IWYU warnings when using catch_all.hpp

GitHub Issues

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #2741 (57b52f2) into devel (47a2c96) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2741      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.01%     
==========================================
  Files         190      190              
  Lines        7855     7855              
==========================================
- Hits         7176     7175       -1     
- Misses        679      680       +1     

@horenmar
Copy link
Member

horenmar commented Sep 9, 2023

  1. You want pragma begin_exports/end_exports
  2. Won't this cause issues where IWYU will try to replace includes of other headers with catch_all.hpp?

@vient
Copy link
Author

vient commented Sep 9, 2023

  1. I'm actually using clangd, they only support most basic pragmas :( https://clangd.llvm.org/guides/include-cleaner#iwyu-pragmas
  2. I checked that clangd does not do this, not sure about original IWYU tool

Copy link

@shahsb shahsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants