Add -Wsign-conversion to the list of common warning flags #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wmbat
force-pushed
the
wmbat/fixing-implicit-conversions
branch
from
249b5f5 to
f28ab91
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## devel #2775 +/- ##
==========================================
- Coverage 91.45% 91.39% -0.06%
==========================================
Files 194 194
Lines 8197 8196 -1
==========================================
- Hits 7496 7490 -6
- Misses 701 706 +5 |
oboukli
reviewed
Oct 26, 2024
| std::vector<ColumnInfo> m_columnInfos; | ||
| ReusableStringStream m_oss; | ||
| int m_currentColumn = -1; | ||
| std::size_t m_currentColumn = 0; |
There was a problem hiding this comment.
Would it be better if this was an iterator?
shahsb
approved these changes
Mar 26, 2025
| std::vector<ColumnInfo> m_columnInfos; | ||
| ReusableStringStream m_oss; | ||
| int m_currentColumn = -1; | ||
| std::size_t m_currentColumn = 0; |
Wmbat
force-pushed
the
wmbat/fixing-implicit-conversions
branch
from
f28ab91 to
1d322a4
Compare
|
Fixed the merge conflicts and switch to using an iterator instead of an index not fully sure why it says I modified so many files though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes all implicit sign conversions and turns on -Wsign-conversion when building catch2. I usually tried to find a good solution to the warning instead of casting.
Ran all the tests on my machine and it seemed good to go
GitHub Issues
Related to #2583