Ensure test class internal linkage for certain template-test types - #3161
Merged
horenmar merged 2 commits intoJun 9, 2026
Merged
Conversation
…ETHOD_2 into the anonymous namespace
…E_METHOD_2 into the anonymous namespace
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3161 +/- ##
==========================================
+ Coverage 91.26% 91.30% +0.03%
==========================================
Files 204 204
Lines 8905 8905
==========================================
+ Hits 8127 8130 +3
+ Misses 778 775 -3 🚀 New features to boost your workflow:
|
Member
|
Thanks |
jessecusack
pushed a commit
to OSUGliders/dbd2netcdf
that referenced
this pull request
Jul 27, 2026
Patch release addressing two bug fixes in the test framework: - OOB read when scanning for the start of a broken UTF-8 sequence during linebreaking (catchorg/Catch2#3096) - ODR violation from TEMPLATE_LIST_TEST_CASE_METHOD and CATCH_TEMPLATE_PRODUCT_TEST_CASE (catchorg/Catch2#3161) Test-only dependency (FetchContent); not linked into shipped binaries. Verified: clean Release build, ctest 31/31 passing locally. Closes mousebrains#12 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already reported on the official discord, there exists a severe issue with
TEMPLATE_LIST_TEST_CASE_METHOD.When fixing that I found a similar issue with
TEMPLATE_PRODUCT_TEST_CASE_METHOD.