Change the axis color of workflow metrics to match GitHub theme setting#69
Open
massongit wants to merge 1 commit intocatchpoint:masterfrom
Open
Change the axis color of workflow metrics to match GitHub theme setting#69massongit wants to merge 1 commit intocatchpoint:masterfrom
massongit wants to merge 1 commit intocatchpoint:masterfrom
Conversation
Contributor
Author
|
@rwxdash @suleymanbarman Please review it. |
Contributor
Author
|
@rwxdash @suleymanbarman @serkan-ozal Please review it. |
|
Maybe you can assign them as reviewers to notify them |
Contributor
Author
I do not have permission to assign reviewers... |
|
Can you include a screenshot to show the graphs works well in dark mode |
Contributor
Author
|
I add screenshots to PR description. |
|
I can confirm it looks the same as the screenshot on GitHub mobile on iOS (from the test PR linked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42
I fix this action to automatically change the axis color of workflow metrics to match GitHub theme setting.
FYI: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to
Screenshots
https://github.com/massongit/workflow-telemetry-action/actions/runs/13598930026?pr=1 ( massongit#1 )
Dark mode
Light mode