Use display, rather than publish_display_data#5
Open
jhamrick wants to merge 1 commit intocatherinedevlin:masterfrom
Open
Use display, rather than publish_display_data#5jhamrick wants to merge 1 commit intocatherinedevlin:masterfrom
jhamrick wants to merge 1 commit intocatherinedevlin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message spec in IPython was recently updated, and they no longer support
publish_display_data(see IPEP 13). In particular, if you usenbconvertto convert a notebook that uses the doctester to HTML, the HTML output of "success" (or the failures) doesn't get converted because it's not actually displayed -- this pull request updates the doctester to be in line with IPEP 13, and display the data so that it will work with nbconvert.The message spec stuff is pretty new, though, so understandable if you want to wait a while before merging this. But I thought I'd go ahead and submit a pull request in case anyone else finds this change useful.