fix(catppuccin.ts): borders from black -> overlay0#38
fix(catppuccin.ts): borders from black -> overlay0#38sgoudham merged 3 commits intocatppuccin:mainfrom
Conversation
Yes, it breaks our css and thus will be ENTIRELY IGNORED but we'll change it in another PR. C.F. catppuccin#38 Signed-off-by: Toria <ninetailedtori@uwu.gal>
sgoudham
left a comment
sgoudham
left a comment
There was a problem hiding this comment.
I'm surprised we even set these borders, what happens if you don't set this CSS in the first place? What does it look like?
https://codemirror.net/docs/ref/#h_panels here's the ref for panels! Honestly, they DO make a difference, lemme show you the original! 
|
|
How does it look with overlay0? |
It's alright! But honestly we could...just make it invisible? Or even, I think, undefine it? I'm not sure what upstream sets for that! |
No border does make it look...unclear though. Perhaps we should make that a...1px border? |
|
If we want to keep the border, 1px overlay0 seems like it'd be good |
Sounds good! |
Signed-off-by: Toria <ninetailedtori@uwu.gal>
2 participants
No description provided.