feat(lib/mediawiki): use codex style guide #1962
Conversation
|
Related to #1866 |
|
Can you explain more about what these changes do or fix? |
Sure! Using the latest version of the library, there's cases where table backgrounds and borders use the same colour which is bad for contrast. In addition, there was a few unthemed variables that are used on other MediaWiki wikis but are part of the Codex style guide spec. This is using feat/mediawiki-lib-integrate modified to point to both versions of the libraries as they are not deployed yet. First example, on Wikipedia - Help:Sortable_tables 
_After PR_
Second example, on Wikipedia - Help:Introduction_to_tables_with_Wiki_Markup when signed out. 
_After PR_
Third example, in the footer on Wikipedia. Contrast is improved by a lot, closer to matching the style guide contrast recommendations. 
_After PR_
Fourth example, buttons now have a colour change when pressed. 
_After PR, hover_
_After PR, active_
|
WalkQuackBack
added
4.topic: libraries
| --color-destructive--hover: @maroon; | ||
| --color-destructive--active: @maroon; | ||
| --color-destructive--active: darken(@red, 4%); | ||
| --color-destructive--visited: spin(@red, 15); |
There was a problem hiding this comment.
Hue shifting. I tried using Maroon but I could hardly tell the difference between it being visited and not. I have some issues seeing colours though, so if you think that maroon contrasts well enough feel free to go and apply that!
| --background-color-button-quiet--hover: fade(@text, 2.7%); | ||
| --background-color-button-quiet--active: fade(@text, 8.2%); |
There was a problem hiding this comment.
Do we need to fade text for this?
There was a problem hiding this comment.
These are translucent in the original, so I copied that. I think these should be a fade of accent, actually.
uncenter
removed
the
5.needs: staff-review
2 participants
Use the Wikimedia Codex color design tokens to base the colour bindings.
This makes the appearance of the style more consistent with base Wikipedia.