ENH: Adding data validation for demand drafts (notebook + code) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gggodhwani
requested changes
Jun 27, 2018
Member
gggodhwani
left a comment
gggodhwani
left a comment
There was a problem hiding this comment.
Please see the following comments
| @@ -0,0 +1,99 @@ | |||
| import re | |||
| import json | |||
| from goodtables import validate, check | |||
| def missing_budget_code(errors, cells, row_number): | ||
| ''' | ||
| Check for missing budget codes where particulars are present. | ||
| ''' |
Member
There was a problem hiding this comment.
Add doc for args and return variables
| @check('numbers-only', type='custom', context='body') | ||
| def numbers_only(errors, cells, row_number): | ||
| ''' | ||
| Check if there are numbers only in the Numeric Columns. |
Member
There was a problem hiding this comment.
Add doc for args and return variables
Contributor
Author
|
Let's add them when we can later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.