Fix: handle missing/invalid tile IDs in renderTiles + add unit tests #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the Board component would crash whenever a tile had a missing, null, or otherwise invalid id field. The previous implementation of renderTiles() assumed that every tile contained a valid, non-empty string id, which caused React rendering failures and runtime errors when encountering malformed or user-generated tiles.
This PR adds defensive logic to ensure that renderTiles() safely handles null, undefined, or non-array inputs and filters out any tiles lacking a proper string id. Only valid tiles are rendered, preventing crashes and improving overall client-side robustness.
In addition to the fix, I added a new Jest test suite that verifies correct filtering behavior and confirms that renderTiles(null) and renderTiles(undefined) return empty arrays without throwing errors. All external dependencies were mocked to keep the tests isolated, and the full suite passes successfully.
This change is safe and doesn't affect Redux state, existing board data, or valid tile behavior. It directly addresses and resolves issue #2038.