Security: Overly permissive Content Security Policy allows XSS and untrusted script execution#2151
Open
tomaioo wants to merge 1 commit into
Conversation
The CSP in `public/index.html` is extremely permissive: it allows `'unsafe-inline'`, `'unsafe-eval'`, wildcard `http://*` and `https://*` in `default-src`, and broad `connect-src`/`img-src` values. This significantly weakens browser-side protections and increases the impact of any HTML/JS injection vulnerability. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Overly permissive Content Security Policy allows XSS and untrusted script execution
Problem
Severity:
High| File:public/index.html:L7The CSP in
public/index.htmlis extremely permissive: it allows'unsafe-inline','unsafe-eval', wildcardhttp://*andhttps://*indefault-src, and broadconnect-src/img-srcvalues. This significantly weakens browser-side protections and increases the impact of any HTML/JS injection vulnerability.Solution
Harden CSP by removing
unsafe-inline/unsafe-eval, disallowing wildcard origins, and defining strict directives (script-src,style-src,img-src,connect-src) with explicit trusted domains only. Prefer nonce/hash-based inline script allowances where needed.Changes
public/index.html(modified)