Skip to content

Commit 4468a03

Browse files
authored
Fix bug when closing a dataset (#653)
* Fix bug when closing a dataset * Add changelog entry
1 parent 6ed6432 commit 4468a03

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
## [UNRELEASED] · YYYY-MM-DD
2+
### 🔧 Fixed
3+
- Fix a bug where a dataset could not be closed in the sidebar ([#653](https://github.com/cbrnr/mnelab/pull/653) by [Clemens Brunner](https://github.com/cbrnr))
24

35
## [1.5.0] · 2026-05-21
46
### ✨ Added

src/mnelab/model.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,8 @@ def get_info(self):
523523
info : dict
524524
Dictionary with information on current data set.
525525
"""
526+
if self.current["data"] is None:
527+
self.reload_dataset(self.index)
526528
data = self.current["data"]
527529
fname = self.current["fname"]
528530
ftype = self.current["ftype"]

src/mnelab/widgets/sidebar.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def showCloseButton(self, hovered_item):
290290

291291
def _close_dataset(self, dataset_id):
292292
"""Close a dataset, cascading to descendants with a confirmation dialog."""
293-
descendants = self.parent.model.find_descendants(dataset_id)
293+
descendants = self.parent.window().model.find_descendants(dataset_id)
294294
if descendants:
295295
n = len(descendants)
296296
msg = QMessageBox(self)
@@ -306,7 +306,7 @@ def _close_dataset(self, dataset_id):
306306
msg.setDefaultButton(QMessageBox.StandardButton.Cancel)
307307
if msg.exec() != QMessageBox.StandardButton.Ok:
308308
return
309-
self.parent.model.remove_data_cascade(dataset_id)
309+
self.parent.window().model.remove_data_cascade(dataset_id)
310310

311311

312312
class SidebarWidget(QWidget):

0 commit comments

Comments
 (0)