Skip to content

Conversation

@Lupus590
Copy link
Contributor

@Lupus590 Lupus590 commented May 4, 2022

@Lupus590 Lupus590 marked this pull request as ready for review May 4, 2022 16:23
@SquidDev SquidDev added enhancement An extension of a feature or a new feature. area-Documentation Improving/fixing documentation labels May 5, 2022
Copy link
Member

@SquidDev SquidDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this together. Looking at this, I really think it's worth splitting each section into separate pages - while three are all about modems, the underlying topics are pretty different.

  • Moving items and fluids: I really like what you've done here, especially with the concrete colours - definitely worth linking this page in the inventory and fluid_handler peripheral doc.

  • Wired modems as peripheral connectors: I'm not quite sure what to do with this section. There's some stuff about wired networks already on the main peripheral docs - I'm not sure whether it's worth trying to flesh those out, or if it is worth the extra docs - not sure if people have thoughts on that?

@SquidDev SquidDev changed the title document how to use modems is various ways Document how to use modems is various ways May 18, 2022
@Lupus590
Copy link
Contributor Author

Lupus590 commented Jun 1, 2022

Right, I need to read through these again to check that they flow well and that I haven't deleted something that actually was important. Not going to do that now as I feel quite tired, a job interview at 8am when you're used to getting up at 2pm will do that.

@Lupus590 Lupus590 marked this pull request as draft June 1, 2022 19:58
@SquidDev
Copy link
Member

SquidDev commented Jun 1, 2022

Hope the job interview went well!

@Lupus590
Copy link
Contributor Author

Lupus590 commented Jun 6, 2022

I might move the big bullet point section into its own guide, it's a bit in the way where it is and could still do with being referenced in the item movement page.

@Lupus590 Lupus590 marked this pull request as ready for review June 7, 2022 01:08
@Lupus590 Lupus590 requested a review from SquidDev June 7, 2022 01:08
@Lupus590
Copy link
Contributor Author

Lupus590 commented Jun 7, 2022

Hope the job interview went well!

Well, they offered me the job, so I assume it went well.

@SquidDev
Copy link
Member

SquidDev commented Jun 8, 2022

Oh wow. Congratulations!

@piprett
Copy link
Contributor

piprett commented Sep 22, 2022

What's the status of this PR?

@SquidDev
Copy link
Member

It's on my list of "oh gosh, I should look at this soon". I've got a checkout locally where I've been trying to improve the flow a little, but not super convinced with what I've got.

@Lupus590 Lupus590 marked this pull request as draft October 10, 2023 14:12
@Lupus590 Lupus590 changed the base branch from mc-1.16.x to mc-1.20.x October 10, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Documentation Improving/fixing documentation enhancement An extension of a feature or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants