Fix textutils.pagedTabulate and tabulate#522
Open
dierks-m wants to merge 5 commits intocc-tweaked:mc-1.15.xfrom
Open
Fix textutils.pagedTabulate and tabulate#522dierks-m wants to merge 5 commits intocc-tweaked:mc-1.15.xfrom
dierks-m wants to merge 5 commits intocc-tweaked:mc-1.15.xfrom
Conversation
Initial commit where textutils.pagedTabulate and textutils.tabulate should work as intended
It appears I had failed to update this when last bumping the Forge version. Closes cc-tweaked#521 - we're relying on a feature only added in Forge 31.1.16, and they're using 3.1.14.
Switch to table.pack in order for tabulateCommon to properly error when one of the arguments provided is nil
SquidDev
added
area-CraftOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #487 and just is the 1.15 version of #517 with the two commits cherry-picked over. textutils.pagedTabulate also now correctly prints an entire page before waiting for input.
Due to the inner workings of
makePagedScrollit waits for user input - even when there's no more content to come. See here:https://github.com/SquidDev-CC/CC-Tweaked/blob/e8e2ed9fe521b4b420c5eb93190fa3f1f6f58686/src/main/resources/data/computercraft/lua/rom/apis/textutils.lua#L91-L97
The returned function first scrolls, them asks for input - this is due to
print()doing a lastterm.scroll()at the end with the newline character -pagedPrint()does the same.For that to be fixed, all of
pagedPrint,makePagedScrollandpagedTabulatewould have to be changed.Besides that, the function seems to work as intended.
Other pictures are in #517