Update mousetrap.js (fix for keyup with multiple modifiers) #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to ensure that keyup fires when combination consists of multiple modifiers and ends with a modifier key.
This is the start of namespace feature for keybinding. so for example, ctrl+a.name and ctrl+a.name2 could be triggered with same key combination.
If there was a space+c binding for instance, it would fire when c is pressed and not consider space. Now, any key will check to ensure previous keys are still held before firing. If window loses focus, it will clear the arrays that hold the held and released keys.
|
Will this be merged at some time ? |
|
Yeah, I'm having this exact same issue ... @ccampbell can you take a look? 😄 |
|
Any update on this? |
Author
|
Here are my current mousetrap files.. I'm not sure what i've changed, since it's always a hell to edit. It might include some special case stuff for my own specific use, like if a binding name has a _ character at the beginning, then it will fire regardless of any other keys pressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to ensure that keyup fires when combination consists of multiple modifiers and ends with a modifier key.