Skip to content

Add custom message for 212s, 218s, and 219s#155

Merged
wagnerlmichael merged 8 commits intomainfrom
154-add-text-box-to-homeval-reports-for-pins-in-class-212-218-or-219
Mar 20, 2026
Merged

Add custom message for 212s, 218s, and 219s#155
wagnerlmichael merged 8 commits intomainfrom
154-add-text-box-to-homeval-reports-for-pins-in-class-212-218-or-219

Conversation

@wagnerlmichael
Copy link
Member

@wagnerlmichael wagnerlmichael commented Mar 16, 2026

Closes #154

Examples on staging:

  • 218 -16074030360000
  • 212 -15121160220000

Is it possible that there wouldn't be a 219 in south tri?

SELECT meta_pin, char_class, meta_triad_name FROM pinval.assessment_card
WHERE char_class IN ('219')
AND assessment_year = '2026'
AND meta_triad_name = 'south'

</p>
</div>
{{ end }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right location for this message?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Thought, non-blocking] Hmm, that's a good question. I do think the top of the page is at risk of drowning in alerts:

Image

One way to think of this text might be as an alternate formulation of the desk review note that we show at the bottom of the page, tweaked for specific cases where we know desk review is very likely:

Image

I'm curious what @ccao-jardine thinks!

@wagnerlmichael wagnerlmichael marked this pull request as ready for review March 16, 2026 20:34
Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall structure here looks good! I think we just need to figure out if this is the right spot for this warning, or if we need to move it somewhere else.

Is it possible that there wouldn't be a 219 in south tri?

That does indeed seem to be the case, per default.vw_pin_universe:

select triad_name, count(*)
from default.vw_pin_universe
where class = '219'
and year = '2026'
group by 1
triad_name count
City 11

</p>
</div>
{{ end }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Thought, non-blocking] Hmm, that's a good question. I do think the top of the page is at risk of drowning in alerts:

Image

One way to think of this text might be as an alternate formulation of the desk review note that we show at the bottom of the page, tweaked for specific cases where we know desk review is very likely:

Image

I'm curious what @ccao-jardine thinks!

@ccao-jardine
Copy link
Member

Agreed, we're racking up the alerts here. (Think there's a 212 multicard out there with a same-property sale in its top 5, that could rack up even more alerts?)

I am open to design feedback. I did propose that it's best at the top of the page rather than the bottom. As a user, I'd rather know before seeing the characteristics and sales that this is a special property, rather than reading through all these characteristics and sales and then learning that they might not offer much by way of explanation to the AV. But I am just one user.

Thoughts on adding it as extra text to the first disclaimer?

Transparency is hard.

@jeancochrane
Copy link
Member

jeancochrane commented Mar 17, 2026

Thoughts on adding it as extra text to the first disclaimer?

That seems reasonable! This is how I'm imagining we'd format a consolidated first disclaimer, let me know if you had something else in mind:

⚠️ Disclaimer: This exploratory tool explains how the Assessor's model estimated your home value. It is not the same as the Assessor's "comps" tool for reviewing residential appeal filings, and it is only intended to be used for educational purposes.

This property type does receive an initial estimated value from the sales-based statistical model. But, because the market value of this kind of property can depend on income and expense data not in the statistical model, this property type often receives a new valuation later during analyst review. Because of this, the characteristics and data in this report below might not explain the property's assessed value.

I would also suggest we tweak the language slightly for the sake of clarity (mostly just simplifying and switching to active voice), though I leave the final decision about that up to Nicole:

Since your home is a class {212|218|219} property, analysts at the Assessor's office are likely to change its value during the review process. That's because the market value of this kind of property can depend on income and expense data that are not included in the statistical model. Because of this, the characteristics and sales in this report might not explain your home's assessed value.

@wagnerlmichael
Copy link
Member Author

Thoughts on adding it as extra text to the first disclaimer?

That seems reasonable! This is how I'm imagining we'd format a consolidated first disclaimer, let me know if you had something else in mind:

⚠️ Disclaimer: This exploratory tool explains how the Assessor's model estimated your home value. It is not the same as the Assessor's "comps" tool for reviewing residential appeal filings, and it is only intended to be used for educational purposes.
This property type does receive an initial estimated value from the sales-based statistical model. But, because the market value of this kind of property can depend on income and expense data not in the statistical model, this property type often receives a new valuation later during analyst review. Because of this, the characteristics and data in this report below might not explain the property's assessed value.

I would also suggest we tweak the language slightly for the sake of clarity (mostly just simplifying and switching to active voice), though I leave the final decision about that up to Nicole:

Since your home is a class {212|218|219} property, analysts at the Assessor's office are likely to change its value during the review process. That's because the market value of this kind of property can depend on income and expense data that are not included in the statistical model. Because of this, the characteristics and sales in this report might not explain your home's assessed value.

Works for me. @ccao-jardine let us know what you think about Jean's suggested tweak and I can go ahead and make whatever edits we decide on

@ccao-jardine
Copy link
Member

I like the location and the updated language -- thanks!

Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Mostly just pending the switch to PIN-level class instead of card-level class at this point.

Comment on lines +197 to +198
analyst_review_classes = {"212", "218", "219"}
analyst_review = str(df_target_pin["char_class"].iloc[0]) in analyst_review_classes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion, required] Preserving some discussion that we had over chat yesterday: It's not ideal that we're pulling this class from the first card in the PIN, given that cards can have different classes, and those classes don't necessarily match up with the PIN-level class. We're going to try switching to PIN-level class here, which will require updating the upstream view in data-architecture to include a pin_class column in pinval.assessment_card.

wagnerlmichael and others added 2 commits March 18, 2026 15:28
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
HOMEVAL_ASSESSMENT_CARD_TABLE = "pinval.assessment_card"
HOMEVAL_ASSESSMENT_CARD_TABLE = (
"z_ci_add_pin_class_to_custom_homeval_message_pinval.assessment_card"
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to switch this back

Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, pending the switch back to the prod table reference once ccao-data/data-architecture#1000 lands!

wagnerlmichael and others added 2 commits March 20, 2026 15:11
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
@wagnerlmichael wagnerlmichael merged commit 7f581fb into main Mar 20, 2026
1 check passed
@wagnerlmichael wagnerlmichael deleted the 154-add-text-box-to-homeval-reports-for-pins-in-class-212-218-or-219 branch March 20, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add text box to HomeVal reports for PINs in class 212, 218, or 219

3 participants