Conversation
| ) %>% | ||
| mutate(description = replace_na(description, "")) %>% | ||
| arrange(category) | ||
| arrange(category, variable_name) |
There was a problem hiding this comment.
It was annoying me that variables were not in alphabetical order within category.
| - [assessment_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/assessment_data.parquet) | ||
| - [char_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/char_data.parquet) | ||
| - [complex_id_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/complex_id_data.parquet) | ||
| - [hie_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/hie_data.parquet) | ||
| - [land_nbhd_rate_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/land_nbhd_rate_data.parquet) | ||
| - [training_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/training_data.parquet) | ||
|
|
There was a problem hiding this comment.
Worth double-checking these links work as expected.
There was a problem hiding this comment.
[Praise] Works properly for me!
README.md
Outdated
| 2. Ensure that nearly identical properties are identically valued. For | ||
| some property classes, such as 210 and 295s, we manually adjust | ||
| values such that all identical properties in the same complex | ||
| receive the same predicted value. This is accomplished by replacing | ||
| individual predicted values with the average predicted value for the | ||
| complex. | ||
|
|
||
| 4. Round PIN-level values (typically to the nearest \$1,000). This is | ||
| 3. Round PIN-level values (typically to the nearest \$1,000). This is |
There was a problem hiding this comment.
These changes seem like they weren't previously rendered when they were made in the .Rmd file.
There was a problem hiding this comment.
[Nitpick, required] Ah, it looks like we actually need to change this back by persisting the old version of the text to README.Rmd and rerendering the doc so that it produces the same README.md text for this section that exists on the main branch. We tweaked the text in #372 but it looks like I didn't catch that we forgot to update README.Rmd, we just updated README.md directly.
There was a problem hiding this comment.
Thanks for this! Changelog and links look good, and I think the new feature order is sensible. Just one quick tweak we need to make to the README before we merge to persist a change we made incorrectly in #372.
| - [assessment_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/assessment_data.parquet) | ||
| - [char_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/char_data.parquet) | ||
| - [complex_id_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/complex_id_data.parquet) | ||
| - [hie_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/hie_data.parquet) | ||
| - [land_nbhd_rate_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/land_nbhd_rate_data.parquet) | ||
| - [training_data.parquet](https://ccao-data-public-us-east-1.s3.amazonaws.com/models/inputs/res/2026/training_data.parquet) | ||
|
|
There was a problem hiding this comment.
[Praise] Works properly for me!
README.md
Outdated
| 2. Ensure that nearly identical properties are identically valued. For | ||
| some property classes, such as 210 and 295s, we manually adjust | ||
| values such that all identical properties in the same complex | ||
| receive the same predicted value. This is accomplished by replacing | ||
| individual predicted values with the average predicted value for the | ||
| complex. | ||
|
|
||
| 4. Round PIN-level values (typically to the nearest \$1,000). This is | ||
| 3. Round PIN-level values (typically to the nearest \$1,000). This is |
There was a problem hiding this comment.
[Nitpick, required] Ah, it looks like we actually need to change this back by persisting the old version of the text to README.Rmd and rerendering the doc so that it produces the same README.md text for this section that exists on the main branch. We tweaked the text in #372 but it looks like I didn't catch that we forgot to update README.Rmd, we just updated README.md directly.
|
Thanks for tagging me @wrridgeway - looks like you're raging- question: I notice a number of changes in the data documentation- did you have to do that line by line, or was there a way you bulk exported it from an existing data schema? |
|
Note that the |
This reverts commit 39a00e2.
automatically rendered by running the .Rmd, just a product of adding an additional sort variable. |
3 participants
Updating readme for 2026 tag.