Add linting through ESLint using AirBnB style guide #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschrempf
force-pushed
the
add-linting
branch
2 times, most recently
from
5aacd75 to
950e019
Compare
config.example.yml: Fix indentation and comments
Fix typo in transformGroup
* Remove matrix as long as only one build config is needed * Upgrade checkout and setup-node actions to v3 * Use 'npm ci' instead of 'npm install'
This allows to get CI test results even on feature branches, etc.
fschrempf
force-pushed
the
add-linting
branch
from
950e019 to
8cd757b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds linting using ESLint and the AirBnB style guide. It also applies the automatic fixes created by ESLint. The remaining issues need to be resolved manually.
@AlexRoehm If you generally agree with using linting and also with the chosen style guide, you could merge this and we can start fixing the remaining issues manually until the GitHub CI shows a green tick. If you have other ideas or disagree, just let me know. Thanks!