Improvements for executing query and update. #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. sql supports parameter prefix ":" or "$" or "@"; 2. bind null if `dictionaryArgs` does not contain a key from `pStmt`; 3. not to bind if `pStmt` does not contain a key of `dictionaryArgs`;
Owner
|
At first glance, this looks reasonable and tests pass. Let me look at it a bit more though before I make a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for executing query and update:
dictionaryArgsdoes not contain a key frompStmt;pStmtdoes not contain a key ofdictionaryArgs;The 2 and 3 are useful when
dictionaryArgsis a JSON object, which serialized from an Objective-C object. Some keys need not be stored into database, and some other keys are ignored since their values are nil.With this commit, we donot need create another dictionary which must has the apropos key-values any more.