[HOTFIX] 복수전공 졸업요건 및 탈퇴 계정 재가입 오류 수정 - #334
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
참고 사항
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)
🔗 Related Issue
변경 내용
복수전공 졸업요건 후보 선택
GraduationMajorResolver.resolveDualMajor()에서 주전공 영역 요건을 먼저 확인합니다.탈퇴 계정 레거시 병합 및 재가입
User.absorbFrom()에서isDeleted,deletedAt이 신규 User로 전파되지 않도록 방어합니다.saveAndFlush()로 즉시 반영합니다.검증 결과
./gradlew test --tests com.chukchuk.haksa.domain.graduation.policy.GraduationMajorResolverTest --stacktrace --no-daemon통과../gradlew test --tests com.chukchuk.haksa.domain.user.service.UserServiceUnitTests --stacktrace --no-daemon통과../gradlew test --tests com.chukchuk.haksa.domain.user.service.UserServiceIntegrationTest --stacktrace --no-daemon통과../gradlew test --tests com.chukchuk.haksa.domain.user.model.UserTests --stacktrace --no-daemon통과../gradlew check --stacktrace --no-daemon통과.git diff --check main...HEAD통과.spotlessApplyGradle task가 등록되어 있지 않아 해당 포맷 task는 실행하지 못했습니다.운영 및 문서
남은 위험