chore: introduce breaking changes #120
Draft
+792
−352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 248 228 -20
=========================================
- Hits 248 228 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ccoVeille
force-pushed
the
v2
branch
3 times, most recently
from
6dd7f6a to
895f377
Compare
- package no longer supports converting from bool
true/false are no longer converted to 1/0
These values cannot overflow.
- Convert no longer supports converting from string
You can now use Parse function
- string to number conversion no longer uses base 0 (auto-detect in Go strconv library)
Use Parse function with proper base instead
- Convert no longer returns 0 when conversion fails
It now returns the invalid converted value with the error
- Removed `Input` type (Input=string|bool|Number)
This type was used by Convert function to represent input value.
Now Convert function uses Number type directly.
- Fixed float overflow handling with parse float from string
Previously, it returned an ErrStringConversion error while it's an overflow.
Now it returns the proper overflow error.
Now we return the converted value with error, we can face issues when the architecture provides different results for the same input. For example, -1.0 as uint64 is 18446744073709551615 on Linux/amd64, but 0 on Darwin/arm64. Same for -1 to uint that is 18446744073709551615 on Linux/amd64, but -18446744073709551615 on Darwin/arm64. For this reason, we removed the converted value from the examples that fails depending on the architecture.
|
Moving back to draft as I include the non-breaking changes in the v1 via another PR. Here are the ideas:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package no longer supports converting from bool
true/false are no longer converted to 1/0
These values cannot overflow.
Convert no longer supports converting from string
You can now use Parse function
string to number conversion no longer uses base 0 (auto-detect in Go strconv library)
Use Parse function with proper base instead
Convert no longer returns 0 when conversion fails
It now returns the invalid converted value with the error
Removed
Inputtype (Input=string|bool|Number)This type was used by Convert function to represent input value.
Now Convert function uses Number type directly.
Fixed float overflow handling with parse float from string
Previously, it returned an ErrStringConversion error while it's an overflow.
Now it returns the proper overflow error.
Fixes #82 #86