Mobile enhancements and fixes#2
Draft
cconard96 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review pass of current work to ensure it works well on mobile devices with a focus solely on the display/loading experience at this time.
Tests will be conducted with the following settings in Chrome:
The network throttling probably won't have much effect as in some cases absolutely nothing is needed to be transferred over the network thanks to the use of the PWA plugin which has a service worker that caches static resources. For example, loading the New Computer form needs no data from the GLPI server as it is all part of the client resources and the schema that was retrieved at login.
The CPU throttling is more relevant as the rendering is client-side.