Skip to content

Conversation

carlosmiei
Copy link
Collaborator

@carlosmiei carlosmiei self-assigned this Sep 10, 2025
@carlosmiei
Copy link
Collaborator Author

DEMO

tsx examples/class-example.mts          
futuresSymbolConfig [
  {
    symbol: 'SNTUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '25000'
  },
  {
    symbol: 'CGPTUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '60000'
  },
  {
    symbol: 'SUSHIUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '25000'
  },
  {
    symbol: 'STRAXUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '0'
  },
  {
    symbol: 'BNTUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '5000'
  },
  {
    symbol: 'BANKUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '50000'
  },
  {
    symbol: 'MUBARAKUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '25000'
  },
  {
    symbol: 'MILKUSDT',
    marginType: 'CROSSED',
    isAutoAddMargin: false,
    leverage: 20,
    maxNotionalValue: '50000'

@carlosmiei carlosmiei requested a review from Copilot September 10, 2025 21:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for fetching futures symbol configuration data from the Binance API by introducing a new futuresSymbolConfig method and corresponding type definition.

  • Adds SymbolConfig interface to define the structure of symbol configuration data
  • Implements futuresSymbolConfig method to retrieve symbol configuration from the Binance futures API
  • Updates imports to include the new SymbolConfig type

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/types.ts Adds SymbolConfig interface with symbol configuration properties
src/node-binance-api.ts Implements futuresSymbolConfig method and imports the new type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

time: number
}


Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the extra blank lines before the interface declaration to maintain consistent spacing with the rest of the file.

Suggested change

Copilot uses AI. Check for mistakes.

}


export interface SymbolConfig {
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the extra space before the opening brace to follow consistent formatting.

Copilot uses AI. Check for mistakes.

@carlosmiei carlosmiei merged commit ce9a718 into master Sep 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant