Skip to content

Conversation

tripolskypetr
Copy link
Contributor

According to https://developers.binance.com/docs/wallet/asset/trade-fee this should use /sapi/v1/asset/tradeFee instead of /api/v1/asset/tradeFee

According to https://developers.binance.com/docs/wallet/asset/trade-fee this should use `/sapi/v1/asset/tradeFee` instead of `/api/v1/asset/tradeFee`
@carlosmiei carlosmiei self-assigned this Sep 22, 2025
@carlosmiei
Copy link
Collaborator

@tripolskypetr thanks for your contribution!

@carlosmiei carlosmiei merged commit 399dff4 into ccxt:master Sep 22, 2025
1 check failed
@tripolskypetr
Copy link
Contributor Author

@carlosmiei

I also noticed stop loss orders are broken on a spot market(

orderStatus = await binance.sell("BTCUSDT", 0.0008, 111936, {
    stopPrice: 113672,
    stopLimitPrice: 113672,
    stopLimitTimeInForce: "GTC",
    type: "OCO",
});

Getting an error

734 |         // if (typeof params.icebergQty !== 'undefined') request.icebergQty = params.icebergQty;
735 |         if (params.stopPrice) {
736 |             request.stopPrice = params.stopPrice;
737 |             if (request.type === 'LIMIT')
738 |                 throw Error('stopPrice: Must set "type" to one of the following: STOP_LOSS, STOP_LOSS_LIMIT, TAKE_PROFIT, TAKE_PROFIT_LIMIT');
                            ^
error: stopPrice: Must set "type" to one of the following: STOP_LOSS, STOP_LOSS_LIMIT, TAKE_PROFIT, TAKE_PROFIT_LIMIT
      at order (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:738:23)
      at order (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:688:17)
      at sell (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:775:27)
      at sell (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:774:16)
      at <anonymous> (C:\Users\User\Documents\GitHub\one-master\build\index.mjs:16541:33)

Could you please give me relevant example cause all sources from the internet gives the code which does not work

@tripolskypetr
Copy link
Contributor Author

#962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants