Skip to content

Conversation

carlosmiei
Copy link
Collaborator

No description provided.

@carlosmiei carlosmiei requested a review from Copilot September 24, 2025 15:02
@carlosmiei carlosmiei self-assigned this Sep 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for OCO (One-Cancels-Other) orders to the Binance API client by introducing a new order type and dedicated method for creating OCO orders.

  • Adds 'OCO' as a new OrderType in the type definitions
  • Modifies the existing order method to handle OCO orders with appropriate endpoint routing and parameter handling
  • Introduces a new ocoOrder method specifically for creating OCO orders with simplified parameters

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/types.ts Adds 'OCO' to the OrderType union type
src/node-binance-api.ts Updates order method to handle OCO orders and adds new ocoOrder method
examples/oco-order.ts Provides example usage of the new ocoOrder functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

symbol: symbol,
side: side,
type: type
// type: type
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out type: type assignment followed by conditional assignment creates confusion. Consider removing the commented line and keeping only the conditional assignment for clarity.

Suggested change
// type: type

Copilot uses AI. Check for mistakes.

@carlosmiei carlosmiei merged commit 458848f into master Sep 24, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant